Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added the ability to optionally specify workers_ami_id #5

Merged
merged 1 commit into from
Jun 8, 2018
Merged

added the ability to optionally specify workers_ami_id #5

merged 1 commit into from
Jun 8, 2018

Conversation

brandonjbjelland
Copy link
Contributor

@brandonjbjelland brandonjbjelland commented Jun 8, 2018 •
edited
Loading

PR o'clock

Description

workers_ami_id now made an optional variable, lowering the bar for a newcomer trying the module. If not specified, a data search is done to find the latest AWS blessed EKS AMI on your behalf.

Checklist

  • terraform fmt and terraform validate both work from the root and examples/eks_test_fixture directories (look in CI for an example)
  • Tests for the changes have been added and passing (for bug fixes/features) - test updated and manually modified to prove this works.
  • Test results are pasted in this PR (in lieu of CI) - not yet passing, upstream bug
  • Docs have been added/updated (for bug fixes/features) - readme updated by terraform-doc. nothing more needed
  • Any breaking changes are noted in the description above. - not a breaking change

@brandonjbjelland brandonjbjelland changed the title added the ability to optionally specify worker_image_id added the ability to optionally specify workers_ami_id Jun 8, 2018
@brandonjbjelland brandonjbjelland merged commit 72a438f into master Jun 8, 2018
@brandonjbjelland brandonjbjelland deleted the feature/add_optional_dynamic_ami_search branch June 8, 2018 08:05
lisfo4ka added a commit to lisfo4ka/terraform-aws-eks that referenced this pull request Aug 20, 2021
@lisfo4ka
Do not override volumes Name tag and do not add tag if propagate_at_l…
f2f0b07 
…aunch=false (terraform-aws-modules#5)

* feat: Tags passed into worker_groups_launch_template extend var.tags for the volumes
lisfo4ka added a commit to lisfo4ka/terraform-aws-eks that referenced this pull request Oct 26, 2021
@lisfo4ka
Do not override volumes Name tag and do not add tag if propagate_at_l…
a2bd85b 
…aunch=false (terraform-aws-modules#5)

* feat: Tags passed into worker_groups_launch_template extend var.tags for the volumes
lisfo4ka added a commit to lisfo4ka/terraform-aws-eks that referenced this pull request Oct 28, 2021
@lisfo4ka
Do not override volumes Name tag and do not add tag if propagate_at_l…
6a7f106 
…aunch=false (terraform-aws-modules#5)

* feat: Tags passed into worker_groups_launch_template extend var.tags for the volumes
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brandonjbjelland